Failed to return ES_WIFI_STATUS_OK of function ES_WIFI_HardResetModule

[AReducer]

Caution
At the return point of ES_WIFI_HardResetModule

STM32CubeL4/Projects/B-L475E-IOT01A/Applications/WiFi/Common/Src/es_wifi.c

Line 1530 in 692ff21

return (ret > 0) ? ES_WIFI_STATUS_OK : ES_WIFI_STATUS_ERROR;

It requires the return value of Obj->fops.IO_Init (i. e. if it's set, SPI_WIFI_Init) as ret >0. However, when mode passed to SPI_WIFI_Init is ES_WIFI_RESET, it calls SPI_WIFI_ResetModule and return its return value. The called reset module function only has two possible of return values, 0 or -1. So, the ES_WIFI_HardResetModule can only return the case of ES_WIFI_STATUS_ERROR.

ES_WIFI_Status_t ES_WIFI_HardResetModule(ES_WIFIObject_t *Obj)
{
  int ret = 0;
  LOCK_WIFI();
  if (Obj->fops.IO_Init != NULL)
  {
    ret = Obj->fops.IO_Init(ES_WIFI_RESET); // SPI_WIFI_Init
  }
  UNLOCK_WIFI();
  return (ret > 0) ? ES_WIFI_STATUS_OK : ES_WIFI_STATUS_ERROR;
}

Describe the set-up

• stm32L475 discovery board
• STM32 System Workbench

Additional context
change it to ret == 0 may address this issue.

[RJMSTM]

Hello @AReducer,

I've tested the application, and everything appears to be functioning correctly. Could you please provide more specific details about the problem you're encountering? Any additional information would be helpful to understand and address the issue more effectively.

Regards,

[AReducer]

Obj->fops.IO_Init is called as

STM32CubeL4/Projects/B-L475E-IOT01A/Applications/WiFi/Common/Src/es_wifi_io.c

Line 144 in 692ff21

int8_t SPI_WIFI_Init(uint16_t mode)

then it return SPI_WIFI_ResetModule 's return value rc

STM32CubeL4/Projects/B-L475E-IOT01A/Applications/WiFi/Common/Src/es_wifi_io.c

Line 194 in 692ff21

rc = SPI_WIFI_ResetModule();

rc is 0 to be successful.

STM32CubeL4/Projects/B-L475E-IOT01A/Applications/WiFi/Common/Src/es_wifi_io.c

Line 234 in 692ff21

return 0;

thus, ret here is 0 to be successful case. But it returns ES_WIFI_STATUS_ERROR. Shall it return ES_WIFI_STATUS_OK?

STM32CubeL4/Projects/B-L475E-IOT01A/Applications/WiFi/Common/Src/es_wifi.c

Line 1530 in 692ff21

return (ret > 0) ? ES_WIFI_STATUS_OK : ES_WIFI_STATUS_ERROR;

[RJMSTM]

ST Internal Reference: 185903