Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer review by garyzhubc #4

Open
garyzhubc opened this issue Dec 12, 2018 · 0 comments
Open

Peer review by garyzhubc #4

garyzhubc opened this issue Dec 12, 2018 · 0 comments

Comments

@garyzhubc
Copy link

Cecy it's good to see that you eventually did this last homework wonderfully. Here are a few highlights:

  • You have rich data source and you were not limited to the ones that were suggested. For example NYT.
  • The Harry Potter dataset looks interesting! I didn't know there were that many muggle-born in Gryffindor. I feel magical after viewing your repo.
  • All features were coded as functions! I can see how you are dynamically integrating the skills we acquired in this class.
  • I like the format of your markdown, such as using tabs for the questions and table of content.
  • I wonder if there is easier way to convert list to table.

Congratulations on the good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant