TA comments

[ChadFibke]

Coding Style

The good 👍

• Good amount of code chunk comments to explain more complex code!

• Code is readable, nicely spaced, and each layer serves its on purpose!

• Created object names are informatively named!

Needs work 👎

• NA

Coding Strategy

The good 👍

• Effectively used CSS selectors.

• Some dataset evaluation.

Needs work 👎

• The overall output has unnecessary variables like _Id, school, _v in Gryffindor_students.csv; _Id in spells.csv. If the variable doesn't have any variability (everyone has the same value), or add add any information you should leave it out. Think "parsimony"!

• Also be sure to use more effective variable names in your stored data. The variable X in Simpson_best_chapters.csv is not helping! If you are scarping data from the web you want it to make sense the day you store it to the day you come back to the data!

• You scrapped data of the web, but you only show us the head of the data (in case of the simpson data). We were hoping for more exploration, and more explorable data! For example, you could have looked at a different simpson data set, or showed us how many characters are introduced overtime with your simpson data!

• If the title is starting with an integer you should use a more exact search pattern. What if you have "Hommer plans to run for president in 2019."? Your previous method may remove that from the description!

gsub('$[0-9]{1,3}\\. ', '', string)

• Try to use a more diverse set of selectors including: class, ID, descendent selection, and combination selector methods! Using these selectors will help you do more with less code!

Creativity & Ease of Access

The good 👍

• Easy navigation from canvas to your repo!

• Thanks for provided a detailed README showing all your websites and explains your repo content.

• The use of TOC and r markdown syntax make the report easier to follow.

• wow factors include: Made a real time function to see the weather and news! Interesting use of ifelse to pick from business, world, and political news!

Needs work 👎

• Your main repo has a lot of unsorted data files, which will overwhelm readers as the repo grows! For next time please place these datasets into a data folder. You could even have the sub directories Simpson_data and Wizard_data. This would help with the organization.

• Using an API/httr and Rcurl for your real time news and weather functions would have been more appropriate then the static scrapping method!