Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peer review for hw09 #2

Open
g-ziyan opened this issue Dec 4, 2018 · 0 comments
Open

Peer review for hw09 #2

g-ziyan opened this issue Dec 4, 2018 · 0 comments

Comments

@g-ziyan
Copy link

g-ziyan commented Dec 4, 2018

Topic Excellent Satisfactory Needs Work
Coding style ✔️
Coding strategy ✔️
Achievement, creativity ✔️
Ease of access ✔️

Remarks:

  • A good analysis of the letter frequencies. You could get further by sorting them or things like that.
  • Complete working pipeline. 👍
  • The link of Makefile should be offered in the README file.
  • Adding some comments in your Makefile would make it more readable.

Great work overall!
Ziyan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@g-ziyan