Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer-review-hw09 #3

Open
aleurcelay opened this issue Dec 6, 2018 · 0 comments
Open

Peer-review-hw09 #3

aleurcelay opened this issue Dec 6, 2018 · 0 comments

Comments

@aleurcelay
Copy link


"Peer-Review HW-09 for iyaniwura"


Topic Excellent Satisfactory Needs Work
Coding style ✔️
Coding strategy ✔️
Achievement, creativity ✔️
Ease of access ✔️

Remarks:

Hello @iyaniwura 🙋, great work!

Please read my remarks below,

  1. Your README is very descriptive and clearly explains what you did for this assignment.

  2. It is great to see that you made your pipeline from scratch to accomplish an analyisis other than the words one. From reviewing your assignment I learned how to create a simple pipeline by myself, thanks! :)

  3. I was able to run make and clean without any issues, so your Makefile works!

  4. As a suggestion, you can use mkdir to make subdirectories and organize more your repo.

  5. If you wanted to just change one of the plots instead of the whole report, you could export the plots and add them as a dependency for your analysis.

Overall I think you did a really good job and you put extra effort for this assignment :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant