You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I enjoy your clean and detailed README file, it helps reader to understand what you have done.
You put a lot of work into this assignment and it showed! It's awesome to see you created extra Makefile and used gapminder dataset.
Weaknesses
When I run make all in my computer, it comes out some errors like this(maybe those errors only on my computer? I'm not sure about it, contact me if I was wrong)
In the main folder make: Rscript: No such file or directory make: *** [histogram.tsv] Error 1
In Gapminder folder, make: Rscript: No such file or directory make: *** [gap_extract.csv] Error 1
In the Words folder make: Rscript: No such file or directory make: *** [histogram.tsv] Error 1
Please add more comments to your code, it will helpful for your future review.
Overall, good job! 🥇
The text was updated successfully, but these errors were encountered:
Peer Review 9 for iyaniwura
Remarks:
Strengths
Weaknesses
When I run
make all
in my computer, it comes out some errors like this(maybe those errors only on my computer? I'm not sure about it, contact me if I was wrong)make: Rscript: No such file or directory
make: *** [histogram.tsv] Error 1
make: Rscript: No such file or directory
make: *** [gap_extract.csv] Error 1
make: Rscript: No such file or directory
make: *** [histogram.tsv] Error 1
Please add more comments to your code, it will helpful for your future review.
Overall, good job! 🥇
The text was updated successfully, but these errors were encountered: