Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer Review 09 #1

Open
Irissq28 opened this issue Dec 1, 2018 · 0 comments
Open

Peer Review 09 #1

Irissq28 opened this issue Dec 1, 2018 · 0 comments

Comments

@Irissq28
Copy link

Irissq28 commented Dec 1, 2018

Peer Review 9 for iyaniwura

Topic Excellent Satisfactory Needs Work
Coding style ✔️
Coding strategy ✔️
Presentation: graphs ✔️
Presentation: tables ✔️
Achievement, creativity ✔️
Ease of access ✔️

Remarks:


Strengths

  • I enjoy your clean and detailed README file, it helps reader to understand what you have done.
  • You put a lot of work into this assignment and it showed! It's awesome to see you created extra Makefile and used gapminder dataset.

Weaknesses

  • When I run make all in my computer, it comes out some errors like this(maybe those errors only on my computer? I'm not sure about it, contact me if I was wrong)

    • In the main folder
      make: Rscript: No such file or directory
      make: *** [histogram.tsv] Error 1
    • In Gapminder folder,
      make: Rscript: No such file or directory
      make: *** [gap_extract.csv] Error 1
    • In the Words folder
      make: Rscript: No such file or directory
      make: *** [histogram.tsv] Error 1
  • Please add more comments to your code, it will helpful for your future review.

Overall, good job! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant