Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TA comment #2

Open
Rashedul opened this issue Dec 4, 2018 · 2 comments
Open

TA comment #2

Rashedul opened this issue Dec 4, 2018 · 2 comments

Comments

@Rashedul
Copy link

Rashedul commented Dec 4, 2018

@aleurcelay
Copy link
Collaborator

Hi @Rashedul thanks for your feedback! Could you just clarify why the 85 in the achievement section?
*Making a graph of your pipeline, presented in your README and *Adding more structure to the project folder (perhaps folders such as data, src, doc, or others might be appropriate here?), created by automation where appropriate (with commands such as mkdir) were listed as "wow" factors.

Thank you! :)

@Rashedul
Copy link
Author

Rashedul commented Dec 6, 2018

@aleurcelay thanks for you comment.

Yes, you used some shell command in you makefile. It is obvious that you touched some of the "wow" factors and therefore you got 90+ grades in all sections except achievement. To get 90+ in achievement section, you could prepare the hw from the scratch or, could include scripts that were not taught in the class. But I agree with you that you did the hw perfectly and attempted for at least two "wow" factors. So I adjusted your achievement grade.

Best
Rashedul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants