You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Overall, you've demonstrated that you can work with a Makefile and modify an existing pipeline on a novel analysis, so well done.
Good use of code comments. Your python code is nice to look at. I would suggest you describe what some operations do, like item[::-1]. That would help those unfamiliar with python!
Great organization in your readme and Makefile. Thanks for explaining the pipeline. Nice thought of finding palindromes.
Some suggestions:
I would have liked to see something more than just printing out the palindromes. Maybe some additional analysis, like whats the most common palindrome, or some histogram of length of palindromes maybe, to help us as reader understand more about the nature of palindromes in words data file.
I dont think including the raw html file link in README is helpful at all, I would omit that if I were you 👍
The text was updated successfully, but these errors were encountered:
Peer-Review HW-09 for aidanh14
Some remarks:
item[::-1]
. That would help those unfamiliar with python!Some suggestions:
words
data file.README
is helpful at all, I would omit that if I were you 👍The text was updated successfully, but these errors were encountered: