Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer review - figalit #2

Open
figalit opened this issue Dec 4, 2018 · 0 comments
Open

Peer review - figalit #2

figalit opened this issue Dec 4, 2018 · 0 comments

Comments

@figalit
Copy link

figalit commented Dec 4, 2018

Peer-Review HW-09 for aidanh14

Topic Excellent Satisfactory Needs Work
Coding style ✔️
Coding strategy ✔️
Achievement, creativity ✔️
Ease of access ✔️

Some remarks:

  • Overall, you've demonstrated that you can work with a Makefile and modify an existing pipeline on a novel analysis, so well done.
  • Good use of code comments. Your python code is nice to look at. I would suggest you describe what some operations do, like item[::-1]. That would help those unfamiliar with python!
  • Great organization in your readme and Makefile. Thanks for explaining the pipeline. Nice thought of finding palindromes.

Some suggestions:

  • I would have liked to see something more than just printing out the palindromes. Maybe some additional analysis, like whats the most common palindrome, or some histogram of length of palindromes maybe, to help us as reader understand more about the nature of palindromes in words data file.
  • I dont think including the raw html file link in README is helpful at all, I would omit that if I were you 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant