Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer Review 1 #1

Open
Caroline-Seip opened this issue Dec 3, 2018 · 0 comments
Open

Peer Review 1 #1

Caroline-Seip opened this issue Dec 3, 2018 · 0 comments

Comments

@Caroline-Seip
Copy link

Hey Aidan, good job overall on this assignment. Your Makefile ran without errors, and I think doing palindromes was a really fun creative idea. I appreciate how you displayed your table using kable to clean it up, and how you included an .md for easy viewing. I would have preferred if you had instead made the .html viewable however, so that I could see what the .html would look like. There were also some display issues with your README, (# before title) and could have been made more clear and straightforward. It's also unnecessary to have so many duplicate files in your repository- such as a README.html, just makes it more messy than necessary.

Cool Makefile, happy holidays! ❄️ ⛄️ 🎁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant