Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peer-Review HW-07 for katiezinn #3

Open
liming17 opened this issue Nov 18, 2018 · 0 comments
Open

Peer-Review HW-07 for katiezinn #3

liming17 opened this issue Nov 18, 2018 · 0 comments

Comments

@liming17
Copy link

Peer-Review HW-07 for katiezinn

Topic Excellent Satisfactory Needs Work
Coding style ✔️
Coding strategy ✔️
Presentation: graphs NA
Presentation: tables NA
Achievement, creativity ✔️
Ease of access ✔️

Remarks:

  • Clear README file, which summarize the work you did.
  • The function you built is very interesting 👍 and it runs correctly~
  • For the vignettes, it would be better if you add a md file or a more reader-friendly file next time :)
  • In the test.R, it would be great if you could test more situation:)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@liming17