Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peer-review for hw01 #2

Open
vetlebh opened this issue Sep 24, 2018 · 0 comments
Open

peer-review for hw01 #2

vetlebh opened this issue Sep 24, 2018 · 0 comments

Comments

@vetlebh
Copy link

vetlebh commented Sep 24, 2018

Peer-Review HW-01 for aleurcelay

Topic Excellent Satisfactory Needs Work
Coding style ✔️
Coding strategy ✔️
Presentation: graphs ✔️
Presentation: tables ✔️
Achievement, creativity ✔️
Ease of access ✔️

Remarks:

  • In general a well written, organized code. Nice with good comments explaining the code chunks. Interesting statistics, show you handle different aggregations, functions, data wrangling and plotting. Also very nice README file showcasing a lot of different GitHub-Flavoured Markdown. Interesting to get to know a little bit about you, and a wonderful picture of a forest, which healed my soul after a hard weekend.
  • I really liked the aggregated summarize function, which I have not seen before. You were able to make a very interesting statistic in very few lines of code. I also did not know that Rmd files supported emojis, which was a nice touch 🥇
  • I would have liked to see a link to the code file from the README file. Especially in big repositories it can be hard for the reviewer to find the correct files, and therefore it is nice with links directly from the README.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant