Fix the way configuration was being bound, to make it work for complex objects. #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ex object. Update the tests so they use an actual IConfiguration because we're not able to Mock .Bind().
Robbware
added
the
bug
antoineatstariongroup
approved these changes
Oct 6, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Essentially, doing a .GetSection() doesn't retrieve the whole object - for that we have to use .Bind() (which I tried at first, but ran into issues while doing unit tests).
For the unit tests to work, a IConfiguration container had to be built, because there's no way to mock the .Bind() method to make it work for tests (it's a static method).