-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Categories hierarchy : Fix #411 #418
Conversation
Codecov Report
@@ Coverage Diff @@
## development #418 +/- ##
===============================================
+ Coverage 78.46% 78.57% +0.11%
===============================================
Files 304 309 +5
Lines 6817 6918 +101
Branches 697 704 +7
===============================================
+ Hits 5349 5436 +87
- Misses 1257 1269 +12
- Partials 211 213 +2
|
please use semantics from UML (should have been more explicit in the original feature request) the direction of the arrow is from subclass to superclass and the arrow is an open arrow, see example image below (the "extends"word does not need to be in the arrow) Some more requests: in case the Category IsAbstarct, set the caption to Italics. In case the category is deprecated, use dotted line as style for box |
@samatrhea Yes, i have added the Open arrow. however it is not displayed (COMETwebapp/wwwroot/images/UML_Open_arrow.svg) i will try to fix that and add the Italic caption for the abstract categories |
COMETwebapp/ViewModels/Components/ReferenceData/CategoriesTableViewModel.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the impression that in the current solution the arrows are pointing in the wrong direction. The direction should be from subclass to superclass: subclass ---> superclass; please have a look at the diagram i provided as an example
7854ac7
to
5864c94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor editorial change of formatting
COMETwebapp/Components/ReferenceData/CategoryNodeComponent.razor.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small editorial problem and a possible improvement.
Global question: What happen on the diagram if one of the category in the category hierarchy is deprecated?
COMETwebapp/ViewModels/Components/ReferenceData/CategoriesTableViewModel.cs
Show resolved
Hide resolved
COMETwebapp/ViewModels/Components/ReferenceData/CategoryHierarchyDiagramViewModel.cs
Show resolved
Hide resolved
COMETwebapp/ViewModels/Components/ReferenceData/ICategoriesTableViewModel.cs
Show resolved
Hide resolved
Now if a category is deprecated, the diagram is updated also on session refresh |
Kudos, SonarCloud Quality Gate passed! 0 Bugs 86.8% Coverage The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
Prerequisites
Description
Fix #411
Display categorties hierarchy using z-diagram (needs some adjustments to display the diagram on the right of the datagrid)