You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using name-replace (or name-replace*), if a name cannot be used then no message is provided to inform the user.
As an example of why this is important. I recently had a proof that was previously working fail after importing closest_approach_2D from vectors in the NASA library. The proof failed because after the import a renaming that used names x1, x2, y1, and y2 only used the y1 and y2 names, leaving the expressions to be renamed x1 and x2 alone. Those names were invalid because vectors@closest_approach_2D imported reals@quad_minmax, which imported reals@quadratic, which defined x1 and x2 as macros (which doesn't seem like a great idea to me, but that's another story, see issue #84).
Ideally, when this strategy failed, I would have been told that the strategy was not entirely successful and then told where the name conflict came from.
NB: the newly imported closest_approach_2D was added to help me with a completely different lemma, so it potentially could've been a long time between when I added that import and when I detected that my previously working proof was no longer working. Luckily, it was close enough in time that my first thought was to comment out that import to determine it was the culprit.
The text was updated successfully, but these errors were encountered:
When using
name-replace
(orname-replace*
), if a name cannot be used then no message is provided to inform the user.As an example of why this is important. I recently had a proof that was previously working fail after importing
closest_approach_2D
fromvectors
in the NASA library. The proof failed because after the import a renaming that used namesx1
,x2
,y1
, andy2
only used they1
andy2
names, leaving the expressions to be renamedx1
andx2
alone. Those names were invalid becausevectors@closest_approach_2D
importedreals@quad_minmax
, which importedreals@quadratic
, which definedx1
andx2
as macros (which doesn't seem like a great idea to me, but that's another story, see issue #84).Ideally, when this strategy failed, I would have been told that the strategy was not entirely successful and then told where the name conflict came from.
NB: the newly imported
closest_approach_2D
was added to help me with a completely different lemma, so it potentially could've been a long time between when I added that import and when I detected that my previously working proof was no longer working. Luckily, it was close enough in time that my first thought was to comment out that import to determine it was the culprit.The text was updated successfully, but these errors were encountered: