Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS and tvOS 15 simulator issues #108

Open
defagos opened this issue Sep 15, 2021 · 3 comments
Open

iOS and tvOS 15 simulator issues #108

defagos opened this issue Sep 15, 2021 · 3 comments

Comments

@defagos
Copy link
Member

defagos commented Sep 15, 2021

The iOS 15 and tvOS 15 simulator has a few issues which make some tests fail. Behavior is correct when the same behavior is tested on device, fortunately.

We should check if this issue is fixed in later versions or maybe report an issue to Apple.

Issue type

Other: Simulator bug

Description of the problem

Here are the tests which currently fail:

  1. -testOnDemandPlaybackStartAtTimeWithTolerances: Starting around a position fails in the simulator. This can also be verified by tweaking the SRG Media Player demo to start around some position (the player struggles to start). The same modified demo project run on device works fine, as does the UT in the iOS 14 simulator.
  2. -testStartTimeAroundBeginningOfSegmentWithSelection and -testStartTimeAroundEndOfSegmentWithSelection: Same issue due to position tolerances being used.

Environment information

  • Library version: Tested with 6.1.4 (development version).
  • iOS / tvOS version: 15.0
  • Device: Simulator

Reproducibility

Always reproducible

Steps to reproduce

  1. Comment out the #warning lines in the source code.
  2. Run the unit tests in the iOS or tvOS 15 simulator.
@defagos
Copy link
Member Author

defagos commented Sep 15, 2021

When investigating UT issues in the iOS / tvOS 15.0 simulator I removed two tests that were testing readyForDisplay, failing with the iOS 15.0 simulator. These flags are best tested interactively IMHO, especially as we cannot run the tests on a device. With appropriate readyForDisplay logging in SRGMediaPlayerView I interactively checked for the flat view (AVPlayerView) as well as for the monoscopic / stereoscopic views that:

  • The player view starts not ready for display.
  • Starting playback makes the view ready for display.

This is true whether the view is installed or not in a view hierarchy, as can be checked with the inline demo.

@defagos
Copy link
Member Author

defagos commented Nov 2, 2021

Not fixed in the 15.1 simulator.

@defagos
Copy link
Member Author

defagos commented Nov 17, 2021

Not fixed in the 15.2 beta 2 simulator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants