Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRM-specific messages and support link #162

Open
4 tasks
defagos opened this issue Nov 29, 2018 · 1 comment
Open
4 tasks

DRM-specific messages and support link #162

defagos opened this issue Nov 29, 2018 · 1 comment

Comments

@defagos
Copy link
Member

defagos commented Nov 29, 2018

One of our stories asked us to display a DRM-specific error message in Letterbox, letting the user access more information in Safari by tapping on a dedicated button.

This story was implemented but could not work because DRM errors are not correctly forwarded from the resource loader delegate to AVPlayer, and thus to SRGMediaPlayerController, because of an AVFoundation bug.

Once this issue has been fixed, and if this still makes sense, we can implement the desired message. What remains to be done:

  • Rebase the feature/drm-external-link
  • Make SRG Content Protection errors public, and add a type information to make a difference between Akamai and FairPlay issues.
  • Update the existing SRGLetterboxErrorView implementation to only display errors for FairPlay.
  • Check that the resource loader issue preventing correct UI behavior has been fixed, or find a proper workaround.
@defagos
Copy link
Member Author

defagos commented Jun 30, 2022

We probably weren't lucky when we first investigated this need, as having non-zero integer error codes in Objective-C, or integer non-zero enum values in Swift, allows the errors to be better propagated. Note that the error message itself seems to be correctly propagated since iOS 15, though the code is correctly propagated on iOS 14. I didn't test earlier versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant