Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid expectations for periods of time #1097

Closed
1 task done
defagos opened this issue Dec 12, 2024 · 0 comments · Fixed by #1099
Closed
1 task done

Avoid expectations for periods of time #1097

defagos opened this issue Dec 12, 2024 · 0 comments · Fixed by #1099
Assignees
Labels
enhancement New feature or request

Comments

@defagos
Copy link
Member

defagos commented Dec 12, 2024

As a Pillarbox developer I need UTs on CI agents to run reliably.

Currently tests capturing values emitted from publishers might fail if the period of time is short, which can be depend on runner performance. Setting times that are tool large make tests run for a longer period of time, using shorter times makes them less reliable.

For this reason we should update our tests and wait until an output has been received, then finish the test. This is slightly less strict that what we had (we were testing the absence of values as well, after the expected output has been received) but will help us have a much more reliable CI.

Acceptance criteria

  • Tests that capture values over a period of time have been updated with tests waiting for some output.

Tasks

  • Replace expect... with expectAtLeast in tests.
@defagos defagos converted this from a draft issue Dec 12, 2024
@defagos defagos changed the title Replace _Expect_ during an interval with _Expect at least_ Avoid expectations for periods of time Dec 12, 2024
@defagos defagos added the enhancement New feature or request label Dec 12, 2024
@defagos defagos moved this from 🚧 In Progress to 🍿 Code Review in Pillarbox Dec 12, 2024
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants