Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for correct player version insertion #1092

Closed
1 task done
defagos opened this issue Dec 6, 2024 · 0 comments · Fixed by #1093
Closed
1 task done

Add instructions for correct player version insertion #1092

defagos opened this issue Dec 6, 2024 · 0 comments · Fixed by #1093
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@defagos
Copy link
Member

defagos commented Dec 6, 2024

  • As an SRG SSR analyst I want the player version to be correctly reported in comScore and Commanders Act payloads sent from apps integrating Pillarbox.
  • As a Pillarbox developer I want the player version to be correctly reported in monitoring events sent from apps integrating Pillarbox.
  • As a developer integrating Pillarbox I want correct instructions how to setup my project so that these needs can be guaranteed.

Context

We discovered that recently released SRF apps did not send player version information. Since the player version is extracted by a plugin performing a git blame we easily pinpointed this issue to be related to how the SRF apps are distributed, in particular the fact that their delivery workflow was restoring an SPM cache with possibly missing tags.

Acceptance criteria

  • Improve documentation to mention issues related to the use of cached SPM packages in release workflows (always use clean build).

Tasks

  • Document the above.
@defagos defagos converted this from a draft issue Dec 6, 2024
@defagos defagos changed the title SRF News versioning issue Add instructions for correct player version insertion Dec 6, 2024
@defagos defagos added the documentation Improvements or additions to documentation label Dec 6, 2024
@defagos defagos self-assigned this Dec 6, 2024
@defagos defagos moved this from 📋 Backlog to 🚧 In Progress in Pillarbox Dec 6, 2024
@defagos defagos linked a pull request Dec 6, 2024 that will close this issue
4 tasks
@defagos defagos moved this from 🚧 In Progress to 🍿 Code Review in Pillarbox Dec 6, 2024
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant