From 697fa69ee9bd80586b1239ad205946ae36a5f52e Mon Sep 17 00:00:00 2001
From: Walid Kayhal <3347810+waliid@users.noreply.github.com>
Date: Wed, 4 Dec 2024 07:32:20 +0100
Subject: [PATCH] Fix doc

---
 .github/workflows/pull-request.yml | 92 +++++++++++++++---------------
 Makefile                           |  4 +-
 Scripts/generate-documentation.sh  | 14 +++--
 3 files changed, 56 insertions(+), 54 deletions(-)

diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml
index 1dde5bb9..b8397da7 100644
--- a/.github/workflows/pull-request.yml
+++ b/.github/workflows/pull-request.yml
@@ -4,15 +4,15 @@ name: Pull Request
 on: push  # yamllint disable-line rule:truthy
 
 jobs:
-  check-quality:
-    name: 🔎 Check quality
-    runs-on: macos-latest
-    steps:
-      - name: Checkout code
-        uses: actions/checkout@v4
+  # check-quality:
+  #   name: 🔎 Check quality
+  #   runs-on: macos-latest
+  #   steps:
+  #     - name: Checkout code
+  #       uses: actions/checkout@v4
 
-      - name: Run the quality check
-        run: make check-quality
+  #     - name: Run the quality check
+  #       run: make check-quality
 
   build-documentation:
     name: 📚 Build documentation
@@ -24,46 +24,46 @@ jobs:
       - name: Build the documentation
         run: make doc
 
-  tests:
-    name: 🧪 Tests
-    runs-on: macos-latest
-    strategy:
-      matrix:
-        platform: [ios, tvos]
-    steps:
-      - name: Checkout code
-        uses: actions/checkout@v4
+  # tests:
+  #   name: 🧪 Tests
+  #   runs-on: macos-latest
+  #   strategy:
+  #     matrix:
+  #       platform: [ios, tvos]
+  #   steps:
+  #     - name: Checkout code
+  #       uses: actions/checkout@v4
 
-      - name: Run tests
-        run: make test-${{ matrix.platform }}
+  #     - name: Run tests
+  #       run: make test-${{ matrix.platform }}
 
-  archive-demos:
-    name: 📦 Archives
-    runs-on: macos-latest
-    strategy:
-      matrix:
-        platform: [ios, tvos]
-    steps:
-      - name: Checkout code
-        uses: actions/checkout@v4
+  # archive-demos:
+  #   name: 📦 Archives
+  #   runs-on: macos-latest
+  #   strategy:
+  #     matrix:
+  #       platform: [ios, tvos]
+  #   steps:
+  #     - name: Checkout code
+  #       uses: actions/checkout@v4
 
-      - name: Add Apple certificate
-        run: |
-          Scripts/add-apple-certificate.sh \
-          $RUNNER_TEMP \
-          ${{ secrets.KEYCHAIN_PASSWORD }} \
-          ${{ secrets.APPLE_DEV_CERTIFICATE }} \
-          ${{ secrets.APPLE_DEV_CERTIFICATE_PASSWORD }}
+  #     - name: Add Apple certificate
+  #       run: |
+  #         Scripts/add-apple-certificate.sh \
+  #         $RUNNER_TEMP \
+  #         ${{ secrets.KEYCHAIN_PASSWORD }} \
+  #         ${{ secrets.APPLE_DEV_CERTIFICATE }} \
+  #         ${{ secrets.APPLE_DEV_CERTIFICATE_PASSWORD }}
 
-      - name: Configure environment
-        run: |
-          Scripts/configure-environment.sh \
-          ${{ secrets.APP_STORE_CONNECT_API_KEY }}
+  #     - name: Configure environment
+  #       run: |
+  #         Scripts/configure-environment.sh \
+  #         ${{ secrets.APP_STORE_CONNECT_API_KEY }}
 
-      - name: Archive the demo
-        run: make archive-demo-${{ matrix.platform }}
-        env:
-          TEAM_ID: ${{ secrets.TEAM_ID }}
-          KEY_ID: ${{ secrets.APP_STORE_CONNECT_KEY_ID }}
-          KEY_ISSUER_ID: ${{ secrets.APP_STORE_CONNECT_KEY_ISSUER_ID }}
-          TESTFLIGHT_GROUPS: ${{ vars.TESTFLIGHT_GROUPS }}
+  #     - name: Archive the demo
+  #       run: make archive-demo-${{ matrix.platform }}
+  #       env:
+  #         TEAM_ID: ${{ secrets.TEAM_ID }}
+  #         KEY_ID: ${{ secrets.APP_STORE_CONNECT_KEY_ID }}
+  #         KEY_ISSUER_ID: ${{ secrets.APP_STORE_CONNECT_KEY_ISSUER_ID }}
+  #         TESTFLIGHT_GROUPS: ${{ vars.TESTFLIGHT_GROUPS }}
diff --git a/Makefile b/Makefile
index 3429dd37..6fec05d5 100644
--- a/Makefile
+++ b/Makefile
@@ -134,9 +134,9 @@ find-dead-code:
 	@echo "... done.\n"
 
 .PHONY: doc
-doc: install-pkgx
+doc: install-pkgx install-bundler
 	@echo "Generating documentation sets..."
-	@pkgx fastlane doc
+	@pkgx bundle exec fastlane doc
 	@echo "... done.\n"
 
 .PHONY: help
diff --git a/Scripts/generate-documentation.sh b/Scripts/generate-documentation.sh
index 1736044d..c60859eb 100755
--- a/Scripts/generate-documentation.sh
+++ b/Scripts/generate-documentation.sh
@@ -1,10 +1,12 @@
 #!/bin/bash
 
+set -e
+
 pushd "$(dirname "$0")/.." > /dev/null || exit
-xcodebuild docbuild -scheme Analytics -destination generic/platform=iOS
-xcodebuild docbuild -scheme Circumspect -destination generic/platform=iOS
-xcodebuild docbuild -scheme Core -destination generic/platform=iOS
-xcodebuild docbuild -scheme CoreBusiness -destination generic/platform=iOS
-xcodebuild docbuild -scheme Monitoring -destination generic/platform=iOS
-xcodebuild docbuild -scheme Player -destination generic/platform=iOS
+xcodebuild docbuild -scheme PillarboxAnalytics -destination generic/platform=iOS
+xcodebuild docbuild -scheme PillarboxCircumspect -destination generic/platform=iOS
+xcodebuild docbuild -scheme PillarboxCore -destination generic/platform=iOS
+xcodebuild docbuild -scheme PillarboxCoreBusiness -destination generic/platform=iOS
+xcodebuild docbuild -scheme PillarboxMonitoring -destination generic/platform=iOS
+xcodebuild docbuild -scheme PillarboxPlayer -destination generic/platform=iOS
 popd > /dev/null || exit