Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwriting of output files (low priority) #43

Open
ltimmerman3 opened this issue Mar 15, 2024 · 1 comment
Open

Overwriting of output files (low priority) #43

ltimmerman3 opened this issue Mar 15, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ltimmerman3
Copy link
Collaborator

Describe the bug
If more than 100 calculations are run in the same directory (use case, vibrational calcs), the calc number is no longer appended and I believe older files are overwritten.

To Reproduce
Most efficiently would be to create a folder of dummy files labeled .out -> .out_100 and then run a sparc calculation

Expected behavior
Continued appendices corresponding to calc number

@ltimmerman3 ltimmerman3 added the bug Something isn't working label Mar 15, 2024
@alchem0x2A
Copy link
Collaborator

@ltimmerman3 I believe that's an limitation in the SPARC's C-source code as pSPARC->OutputFilename has only 2 digits (https://github.com/SPARC-X/SPARC/blob/c92931afaa4c4cbef1bbc90f7db49e2a259b8f90/src/initialization.c#L1518), but I'd argue it's not a bug (at least in the API) itself.

Personally I prefer to just pass a different directory parameter for each of these calculations, as rerunning a calculation in the same directory (with changes to .ion / .inpt files) may cause some unwanted effects when re-parsing the sparc bundle. I agree to adapt the default that keeps all output files in #42, but for this issue maybe it's better separating into different folders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants