Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Claims of Tower and Mine #454

Open
jzy-chitong56 opened this issue Dec 1, 2024 · 1 comment
Open

Claims of Tower and Mine #454

jzy-chitong56 opened this issue Dec 1, 2024 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@jzy-chitong56
Copy link
Contributor

jzy-chitong56 commented Dec 1, 2024

When detection the tower, it may be necessary to make a claim like detection mine
A building cannot be detected as capable of attacking the ground or air until it is completed
Some towers require upgrades before they can be attacked
So need to include both pre upgrade and under construction towers
Similarly, only checking whether it can be attacked will collect ancient trees, and there needs to be a rule to determine whether trees are included


detection mine have a API -- IsUnitType(u,UNIT_TYPE_TOWNHALL)
So the campaign units do not need to be specially hard coded
But the tower doesn't have it, so still need to take into account the campaign units

#289

@jzy-chitong56
Copy link
Contributor Author

After much consideration, I still think it's better to add it to the unit basic table

@SMUnlimited SMUnlimited added the duplicate This issue or pull request already exists label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants