Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash when scanning MRSpectroscopyStorage image #455

Open
rkm opened this issue Feb 27, 2024 · 2 comments · May be fixed by #456
Open

crash when scanning MRSpectroscopyStorage image #455

rkm opened this issue Feb 27, 2024 · 2 comments · May be fixed by #456
Assignees
Labels
bug Something isn't working

Comments

@rkm
Copy link
Member

rkm commented Feb 27, 2024

These shouldn't be scanned for Pixel Data, as they don't have any!

We should probably amend this:

https://github.com/SMI/IsIdentifiable/blob/main/IsIdentifiable/Runners/DicomFileRunner.cs#L235

Using the information fo-dicom provides on the SOPClassUID here:

https://github.com/fo-dicom/fo-dicom/blob/development/FO-DICOM.Core/DicomUID.cs#L31-L43

@rkm rkm added the bug Something isn't working label Feb 27, 2024
@rkm rkm self-assigned this Feb 27, 2024
@howff
Copy link

howff commented Feb 27, 2024

Maybe just check for the PixelData tag being present?

If IsIdentifiable can also scan overlays then check for any of the 16 OverlayData tags being present?

@rkm
Copy link
Member Author

rkm commented Feb 27, 2024

Fair point 😉 I guess the question is whether we want to detect invalid files based on whether the SOPClass specifies pixel data should be present?

Not sure on the overlay handling - will check this.

@rkm rkm linked a pull request Feb 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants