From 9fd2e3e448ee3860539c1d382fe732e77635b975 Mon Sep 17 00:00:00 2001
From: ahmadgaz <gazali.contact@gmail.com>
Date: Thu, 26 Sep 2024 17:02:18 -0700
Subject: [PATCH 1/3] added max height

---
 app/(main)/courses/[id]/@reviews/page.tsx    | 4 ++--
 app/(main)/professors/[id]/@reviews/page.tsx | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/app/(main)/courses/[id]/@reviews/page.tsx b/app/(main)/courses/[id]/@reviews/page.tsx
index 80ca138..81abbf6 100644
--- a/app/(main)/courses/[id]/@reviews/page.tsx
+++ b/app/(main)/courses/[id]/@reviews/page.tsx
@@ -60,9 +60,9 @@ export default function Page({ params }: { params: { id: string } }) {
   const results = data ? data[0] : null;
   const items = data ? data.flatMap((d) => d.items) : [];
   return (
-    <section className="mx-auto flex w-full max-w-content-width items-stretch gap-md px-md pb-lg">
+    <section className="mx-auto flex w-full max-w-content-width items-stretch gap-md px-md">
       <div className="w-[250px] max-lg:hidden">
-        <div className="sticky top-0 flex min-h-[50dvh] w-full flex-col gap-sm pt-lg">
+        <div className="sticky top-0 flex max-h-[100dvh] min-h-[50dvh] w-full flex-col gap-sm overflow-y-auto pt-lg">
           <p className="pb-md">Filters</p>
           <p className="pb-sm text-small-lg">Limit</p>
           <FilterGroup
diff --git a/app/(main)/professors/[id]/@reviews/page.tsx b/app/(main)/professors/[id]/@reviews/page.tsx
index 97a3c01..62ef403 100644
--- a/app/(main)/professors/[id]/@reviews/page.tsx
+++ b/app/(main)/professors/[id]/@reviews/page.tsx
@@ -61,9 +61,9 @@ export default function Page({ params }: { params: { id: string } }) {
   const results = data ? data[0] : null;
   const items = data ? data.flatMap((d) => d.items) : [];
   return (
-    <section className="mx-auto flex w-full max-w-content-width items-stretch gap-md px-md pb-lg">
+    <section className="mx-auto flex w-full max-w-content-width items-stretch gap-md px-md">
       <div className="w-[250px] max-lg:hidden">
-        <div className="sticky top-0 flex min-h-[50dvh] w-full flex-col gap-sm pt-lg">
+        <div className="sticky top-0 flex max-h-[100dvh] min-h-[50dvh] w-full flex-col gap-sm overflow-y-auto pt-lg">
           <p className="pb-md">Filters</p>
           <p className="pb-sm text-small-lg">Limit</p>
           <FilterGroup

From 7c831d8b42eca632e738f5a6611e753e553a4ff4 Mon Sep 17 00:00:00 2001
From: ahmadgaz <gazali.contact@gmail.com>
Date: Thu, 26 Sep 2024 17:34:15 -0700
Subject: [PATCH 2/3] fixed heights for search

---
 app/(main)/courses/search/page.tsx    | 6 +++---
 app/(main)/professors/search/page.tsx | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/app/(main)/courses/search/page.tsx b/app/(main)/courses/search/page.tsx
index 5d50fc8..76919d0 100644
--- a/app/(main)/courses/search/page.tsx
+++ b/app/(main)/courses/search/page.tsx
@@ -35,9 +35,9 @@ export default async function Page({
       <div className="mx-auto w-full max-w-content-width px-md py-lg">
         <p>Search results for &quot;{searchParams.query}&quot;</p>
       </div>
-      <section className="mx-auto flex w-full max-w-content-width items-stretch gap-md px-md pb-lg">
+      <section className="mx-auto flex w-full max-w-content-width items-stretch gap-md px-md">
         <div className="w-[250px] max-lg:hidden">
-          <div className="sticky top-0 flex min-h-[50dvh] w-full flex-col gap-sm pt-lg">
+          <div className="sticky top-0 flex max-h-[100dvh] min-h-[50dvh] w-full flex-col gap-sm overflow-y-auto pb-lg pt-lg">
             <p className="pb-md">Filters</p>
             <p className="pb-sm text-small-lg">Limit</p>
             <FilterGroup
@@ -78,7 +78,7 @@ export default async function Page({
             </LinkBtn>
           </div>
         </div>
-        <div className="flex flex-1 flex-col items-stretch gap-md pt-lg">
+        <div className="flex flex-1 flex-col items-stretch gap-md pb-lg pt-lg">
           <p>{total_results ?? '-'} Courses(s)</p>
 
           {items && total_results > 0 ? (
diff --git a/app/(main)/professors/search/page.tsx b/app/(main)/professors/search/page.tsx
index 48a7109..cecd139 100644
--- a/app/(main)/professors/search/page.tsx
+++ b/app/(main)/professors/search/page.tsx
@@ -23,9 +23,9 @@ export default async function Page({
       <div className="mx-auto w-full max-w-content-width px-md py-lg">
         <p>Search results for &quot;{searchParams.query}&quot;</p>
       </div>
-      <section className="mx-auto flex w-full max-w-content-width items-stretch gap-md px-md pb-lg">
+      <section className="mx-auto flex w-full max-w-content-width items-stretch gap-md px-md">
         <div className="w-[250px] max-lg:hidden">
-          <div className="sticky top-0 flex min-h-[50dvh] w-full flex-col gap-sm pt-lg">
+          <div className="sticky top-0 flex max-h-[100dvh] min-h-[50dvh] w-full flex-col gap-sm overflow-y-auto pb-lg pt-lg">
             <p className="pb-md">Filters</p>
             <p className="pb-sm text-small-lg">Limit</p>
             <FilterGroup
@@ -35,7 +35,7 @@ export default async function Page({
             />
           </div>
         </div>
-        <div className="flex flex-1 flex-col items-stretch gap-md pt-lg">
+        <div className="flex flex-1 flex-col items-stretch gap-md pb-lg pt-lg">
           <p>{total_results ?? '-'} Professor(s)</p>
 
           {items && total_results > 0 ? (

From 6c2cb78f9f161f6176ffa4feeae423aaacbe36bc Mon Sep 17 00:00:00 2001
From: ahmadgaz <gazali.contact@gmail.com>
Date: Thu, 26 Sep 2024 17:36:03 -0700
Subject: [PATCH 3/3] added padding for reviews

---
 app/(main)/courses/[id]/@reviews/page.tsx    | 4 ++--
 app/(main)/professors/[id]/@reviews/page.tsx | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/app/(main)/courses/[id]/@reviews/page.tsx b/app/(main)/courses/[id]/@reviews/page.tsx
index 81abbf6..60d22b1 100644
--- a/app/(main)/courses/[id]/@reviews/page.tsx
+++ b/app/(main)/courses/[id]/@reviews/page.tsx
@@ -62,7 +62,7 @@ export default function Page({ params }: { params: { id: string } }) {
   return (
     <section className="mx-auto flex w-full max-w-content-width items-stretch gap-md px-md">
       <div className="w-[250px] max-lg:hidden">
-        <div className="sticky top-0 flex max-h-[100dvh] min-h-[50dvh] w-full flex-col gap-sm overflow-y-auto pt-lg">
+        <div className="sticky top-0 flex max-h-[100dvh] min-h-[50dvh] w-full flex-col gap-sm overflow-y-auto pb-lg pt-lg">
           <p className="pb-md">Filters</p>
           <p className="pb-sm text-small-lg">Limit</p>
           <FilterGroup
@@ -86,7 +86,7 @@ export default function Page({ params }: { params: { id: string } }) {
         </div>
       </div>
       <SessionProvider>
-        <div className="flex flex-1 flex-col items-stretch gap-md pt-lg">
+        <div className="flex flex-1 flex-col items-stretch gap-md pb-lg pt-lg">
           <p id="reviews">{results?.total_results ?? '-'} Review(s)</p>
           {isLoading || isValidating ? <Skeleton /> : null}
           {!isLoading && !isValidating
diff --git a/app/(main)/professors/[id]/@reviews/page.tsx b/app/(main)/professors/[id]/@reviews/page.tsx
index 62ef403..183f025 100644
--- a/app/(main)/professors/[id]/@reviews/page.tsx
+++ b/app/(main)/professors/[id]/@reviews/page.tsx
@@ -63,7 +63,7 @@ export default function Page({ params }: { params: { id: string } }) {
   return (
     <section className="mx-auto flex w-full max-w-content-width items-stretch gap-md px-md">
       <div className="w-[250px] max-lg:hidden">
-        <div className="sticky top-0 flex max-h-[100dvh] min-h-[50dvh] w-full flex-col gap-sm overflow-y-auto pt-lg">
+        <div className="sticky top-0 flex max-h-[100dvh] min-h-[50dvh] w-full flex-col gap-sm overflow-y-auto pb-lg pt-lg">
           <p className="pb-md">Filters</p>
           <p className="pb-sm text-small-lg">Limit</p>
           <FilterGroup
@@ -87,7 +87,7 @@ export default function Page({ params }: { params: { id: string } }) {
         </div>
       </div>
       <SessionProvider>
-        <div className="flex flex-1 flex-col items-stretch gap-md pt-lg">
+        <div className="flex flex-1 flex-col items-stretch gap-md pb-lg pt-lg">
           <p id="reviews">{results?.total_results ?? '-'} Review(s)</p>
           <form action="/professors/review" className="flex gap-sm">
             <input type="hidden" name="professor_id" value={params.id} />