Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOAP computation hangs when calc is not None in ASE trajectory #83

Open
tsitsvero opened this issue Mar 8, 2022 · 2 comments
Open

SOAP computation hangs when calc is not None in ASE trajectory #83

tsitsvero opened this issue Mar 8, 2022 · 2 comments

Comments

@tsitsvero
Copy link

Seems like there's a bug that hangs computations of SOAP descriptors when the input ASE trajectory snapshots have calculators assigned.
Tried with dscribe 1.2.1.

for mol in mol_traj:
        mol.calc=XTB(method="GFN2-xTB")     
        ... # some calculations
        mol.calc=None # without this line SOAP calculation hangs...

soap = SOAP(
            species=["H", "C", "O"],
            periodic=False,
            rcut=5.0,
            sigma=0.5,
            nmax=5,
            lmax=5,
            average="outer",
            crossover=True,
            dtype='float64
            )


pos = [0,1,4,5]

derivatives, descriptors = soap.derivatives(
            mol_traj,
            positions=[pos] * len(mol_traj),
            n_jobs=10,
            # method="analytical"
            )
@lauri-codes
Copy link
Contributor

That is quite interesting... DScribe is not directly using the calculator objects for anything, so I'm not sure where this is coming from. DScribe could always unassign the calc-property from the systems, but that does not seem right either if the user is not expecting this. Making a copy is an option but it may be quite expensive to do. Needs some thinking, but the workaround of unassigning the calc-property should do before there is a better fix.

@tsitsvero
Copy link
Author

Thanks! I'll also let know if this problem will persist in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants