Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data ingest request from: Zhang et al. 2018 #529

Open
jgizis opened this issue Jul 8, 2024 · 9 comments
Open

Data ingest request from: Zhang et al. 2018 #529

jgizis opened this issue Jul 8, 2024 · 9 comments

Comments

@jgizis
Copy link

jgizis commented Jul 8, 2024

Article title: "Primeval very low-mass stars and brown dwarfs – III. The halo transitional brown dwarfs"

https://academic.oup.com/mnras/article/479/1/1383/5001885

the supplementary data on the website includes X-Shooter visible and IR spectra of L subdwarfs.

@kelle
Copy link
Collaborator

kelle commented Jul 8, 2024

Also has a lot of modeled parameters worth ingesting.

@jgizis , would you or a student be interested in helping with this? E.g., I could put together a spreadsheet with the data we need to ingest and y'all could populate. That would help a lot.

It would also help to upload the relevant spectra files to this issue.

@kelle
Copy link
Collaborator

kelle commented Jul 8, 2024

or @zjzhang42, want to help?

@jgizis
Copy link
Author

jgizis commented Jul 8, 2024

Ok, I will confess that I submitted this because my super-naive attempt to read the fits files with specutils failed, so I can't do that part. But I am happy to populate a table with the fitted parameters from this and the other papers in the series.

(Although I was able to read the supplement file in 2019MNRAS.486.1840Z with no problem.).

@jgizis
Copy link
Author

jgizis commented Jul 8, 2024

Oh, looking at the supplemental files I think Paper IV has supplemental files that include many of the spectra from the earlier papers.

https://academic.oup.com/mnras/article/480/4/5447/5062823

@zjzhang42
Copy link
Contributor

@kelle Hey, just FYI I am not the first author - Zenghua Zhang.

@kelle
Copy link
Collaborator

kelle commented Jul 8, 2024

Ah, apologies for my confusion!

@kelle
Copy link
Collaborator

kelle commented Jul 8, 2024

Here's a sheet to fill out for the missing spectra: SIMPLE Spectra Ingest Template

And for the modeled parameters: SIMPLE Modeled Parameters Template

Are all the sources already in or do they need to be added as well?

@kelle
Copy link
Collaborator

kelle commented Jul 8, 2024

It looks like symmetric uncertainties are provided for all of the modeled parameters. If that's not the case, let's discuss more. There's a plan to deal with asymmetric uncertainties but it's not implemented yet (#484 ).

@kelle kelle added the spectra label Jul 8, 2024
@jgizis
Copy link
Author

jgizis commented Jul 8, 2024

ok. I think the sources are all already in but if any are not I'll let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants