Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Province name mismatches between DAIDE and the diplomacy game engine #61

Open
Jacob-Le opened this issue Feb 1, 2023 · 1 comment
Open

Province name mismatches between DAIDE and the diplomacy game engine #61

Jacob-Le opened this issue Feb 1, 2023 · 1 comment

Comments

@Jacob-Le
Copy link

Jacob-Le commented Feb 1, 2023

The three letter code for certain provinces do not match between the daidepp grammar and the diplomacy game engine.

The ones I have encountered thus far are (diplomacy/daidepp):

  • Gulf of Bothnia (BOT/GOB)
  • English Channel (ENG/ECH)
  • Gulf of Lyon (GOL/LYO)

Encountering one of the diplomacy engine version of the province names causes the parser to crash. This is slightly inconvenient as we have to do some extra translation between DAIDE and diplomacy. Translating from the diplomacy engine to DAIDE for ENG is particularly thorny because it could be referring to either the english channel or England the power.
@aphedges
Copy link
Collaborator

I'd like to point out that you accidentally swapped the values for the Gulf of Lyon. diplomacy uses LYO while daidepp uses GOL. We discovered this when trying to implement a workaround based on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

61-province-name-mismatches-between-daide-and-the-diplomacy-game-engine SHADE-AI/daidepp
2 participants
@Jacob-Le @aphedges