-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ImGui a git submodule of ImGui-SFML #81
Comments
It brings more complexity for almost no gain, I prefer cloning imgui separately on my own. |
I guess you mean submodule? In any case, I'd strongly argue for a submodule instead of git-subtree or subrepo and make sure that the path of ImGUI is configurable. This way, folks who want to manually manage ImGUI can do so; For other folks, the submodule should be enough and works out of the box. |
I think it'll be good to pin specific ImGui commit (I'll use release ones in "master" and releases) and allow to not specify IMGUI_DIR, but get ImGui from subrepository and be sure that the version you'll be using was tested with ImGui-SFML.
The text was updated successfully, but these errors were encountered: