Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic translations don't always play nicely with form-specific Phrase projects #167

Open
shawnbot opened this issue Jan 19, 2021 · 0 comments
Labels
bug Something isn't working translation Translations don't work as expected

Comments

@shawnbot
Copy link
Member

I haven't had time to dig into it, but I discovered a couple of cases in a recent form where strings that we have generic translations checked into git weren't being applied to a form with Phrase translations of its own: the "Next" and "Back" buttons, and generic validation error messages like invalid_email.

There might be a bug in how we're merging the two translation "resource" objects? 🤷

@shawnbot shawnbot added bug Something isn't working translation Translations don't work as expected labels Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working translation Translations don't work as expected
Projects
None yet
Development

No branches or pull requests

1 participant