Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SimpleRepeatedTask #129

Closed
matthiaskoenig opened this issue Mar 27, 2021 · 2 comments
Closed

Remove SimpleRepeatedTask #129

matthiaskoenig opened this issue Mar 27, 2021 · 2 comments
Labels

Comments

@matthiaskoenig
Copy link
Collaborator

matthiaskoenig commented Mar 27, 2021

I see the urgent need to update the RepeatedTask for L1V4. This is the most complex and misunderstood part of SED-ML and at the same time the core of it.

Here my suggestions summarizing other issues

This will make working with the data much easier because things are more consistent and clear from the data side. This would allow us to handle things like #103 and make the generation of the 3D plots easier.

@luciansmith
Copy link
Contributor

Given that all of your suggestions are repeated here from elsewhere except one, I'm going to change this particular issue to be just that single issue: remove SimpleRepeatedTask.

If nobody implements support for SimpleRepeatedTask, we'll end up following this suggestion by default.

@luciansmith luciansmith changed the title Simplify/improve RepeatedTask for L1V4 Remove SimpleRepeatedTask Jun 2, 2021
luciansmith added a commit that referenced this issue Jun 11, 2021
I actually just commented it out, and kept a copy of the original 'abstractTask' on Google Docs, but we decided not to keep this at the last editor's meeting, and it seems like nobody is implementing support for it any time soon.
@luciansmith
Copy link
Contributor

Done! (But easy to reverse if need be.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants