Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name not set for Strateos Parameters #182

Open
tramyn opened this issue Apr 18, 2021 · 2 comments
Open

Name not set for Strateos Parameters #182

tramyn opened this issue Apr 18, 2021 · 2 comments

Comments

@tramyn
Copy link

tramyn commented Apr 18, 2021

This is a feature request to add names to opil.Parameters when converting from a strateos protocol to opil. Intent Parser need names (human readable names), instead of IDs when displaying tables to a Document for users to specify information about a protocol. When IP iterate through these opil.Parameters, IP is picking up parameters without the name field set. It will be valuable for IP to have this feature supported. Refer to CellFreeRiboswitches as an example.

@bbartley
Copy link
Collaborator

I think this was a result of the autogeneration code getting confused about sbol:name vs opil:name. The problem originated in the sbol_factory code and was fixed in SynBioDex/sbol_factory@aea0e2f. A test has been added in OPIL here: 48014d1.

I'm going to go ahead and close this. The fix will be included in the next release 1.0b5

@bbartley bbartley reopened this Apr 20, 2021
@bbartley
Copy link
Collaborator

There is an ontology issue which results in the opil:name property only being created on Parameter objects. All other opil objects default to sbol:name. It is difficult to solve this issue without introducing into the ontology an OPIL base class to affix the opil:name to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants