Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property names are confusing and inconsistent #177

Open
bjkeller opened this issue Apr 7, 2021 · 1 comment
Open

Property names are confusing and inconsistent #177

bjkeller opened this issue Apr 7, 2021 · 1 comment

Comments

@bjkeller
Copy link

bjkeller commented Apr 7, 2021

The naming of properties of classes is confusing.

Specifically:

  1. property names that have the prefix has_ that makes them look like a predicate. ex: ExperimentalRequest.has_parameter_value.
  2. property names in the same class that don't have has_ as a prefix (I prefer this, but what's the convention?): ExperimentalRequest.measurement
  3. property names that don't have anything to do with the cardinality: ExperimentalRequest.measurement
@bbartley
Copy link
Collaborator

bbartley commented Apr 8, 2021

Hi @bjkeller I agree with all the points you make here. It's relatively easy to change the names of attributes to follow a more consistent pattern, but the question for everybody is when is the right time to make these changes? Mainly, I'm concerned about breaking @tramyn 's IntentParser prior to the program meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants