Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to encode temperatures for a measurement? #165

Open
tramyn opened this issue Mar 18, 2021 · 3 comments
Open

How to encode temperatures for a measurement? #165

tramyn opened this issue Mar 18, 2021 · 3 comments
Labels
question Further information is requested representation

Comments

@tramyn
Copy link

tramyn commented Mar 18, 2021

Moved issue from pysbol to here.

To recap:
I have a list of temperature values with units used in a measurement. Intent Parser will need to encode this information using opil.SampleSet objects. @jakebeal and I discussed that the values for temperatures are represented using opil.Measure and added to an opil.SampleSet as a VariableFeature. The template of a opil.SampleSet, however, points to a media template. Is this solution still the best way of encoding temperatures ?

@tramyn tramyn added the question Further information is requested label Mar 18, 2021
@jakebeal
Copy link

Are the temperatures being determined on a per-sample basis, or per-experiment?

If you have to have all samples at the same temperature, then it should be an opil:Parameter.

If different samples can have different temperatures, however, then we do need to put it as variantMeasure values on a VariableFeature in an opil:SampleSet. The problem is where to point the variable property, since SBOL needs that to go to a Feature of the template rather than the full template.

We don't really have a good answer for that, but I believe that pointing it at the media is an appropriate stopgap.

@tramyn
Copy link
Author

tramyn commented Mar 18, 2021

From what I have seen in an ER document, a sample can have varying temperature values. Will Intent Parser have to check in the case that if a list of temperature values are the same per sample, then the temperatures must be encoded as an opil.Parameter ?

@jakebeal
Copy link

No, you can just trust what the document tells you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested representation
Projects
None yet
Development

No branches or pull requests

3 participants