Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specification of a unit for a VariableFeature without having to indicate a value #162

Open
bjkeller opened this issue Mar 10, 2021 · 5 comments

Comments

@bjkeller
Copy link

Request is for a direct way to indicate that the concentration of a component in a combinatorial derivation should be specified.

I am currently doing this by adding a nonsensical measure to the component, such as

        concentration = sbol3.Measure(
            nan,
            SBO.concentration_of_an_entity_pool,
            identity='antibiotic_concentration'
        )
        concentration.description = "Antibiotic concentration"
@bjkeller
Copy link
Author

may relate to #159

@jakebeal
Copy link

I think that for now at least, you need to at least indicate whether you want things in molar vs. grams/liter, etc. Or do you really want to be taking in every possible way a human might think of to express concentration on your end?

We will eventually be able to support more sophisticated reasoning about units, but for now, I think you need to pick one. We'll likely to be able to support generalized prefixing soon (e.g., mM vs. nM), but broader is more complicated.

@bjkeller
Copy link
Author

I'm fine with picking a specific concentration unit. The issue is more with having to specify the value (e.g., nan).

@jakebeal
Copy link

Understood; for now, though, please do specify nan. This is a kludge until we agree on a good way to approach #135

@bbartley
Copy link
Collaborator

Per discussion on Slack, we've decided to use a value of -1.0 as a kludge, since JSON serialization doesn’t allow NaN as a float value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants