Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NZ testing and collection regions, parser and test #198

Merged
merged 2 commits into from
Sep 20, 2022

Conversation

pabloitu
Copy link
Collaborator

@pabloitu pabloitu commented Sep 19, 2022

addresses #176

Type of change:

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2022

Codecov Report

Base: 55.73% // Head: 55.46% // Decreases project coverage by -0.27% ⚠️

Coverage data is based on head (ad340a2) compared to base (74106b9).
Patch coverage: 27.77% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #198      +/-   ##
==========================================
- Coverage   55.73%   55.46%   -0.28%     
==========================================
  Files          20       20              
  Lines        3572     3608      +36     
  Branches      569      579      +10     
==========================================
+ Hits         1991     2001      +10     
- Misses       1460     1482      +22     
- Partials      121      125       +4     
Impacted Files Coverage Δ
csep/core/regions.py 45.59% <27.77%> (-1.16%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wsavran
Copy link
Collaborator

wsavran commented Sep 19, 2022

linking #176

@wsavran wsavran changed the base branch from master to v0.6.1-release-branch September 20, 2022 16:29
@wsavran wsavran changed the base branch from v0.6.1-release-branch to master September 20, 2022 16:31
@wsavran wsavran merged commit 518e750 into SCECcode:master Sep 20, 2022
@pabloitu pabloitu deleted the nz_regions branch September 21, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants