Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug](Core): Err skipping is unsafe. #11

Closed
SARDONYX-sard opened this issue Oct 11, 2023 · 1 comment · Fixed by #12
Closed

[Bug](Core): Err skipping is unsafe. #11

SARDONYX-sard opened this issue Oct 11, 2023 · 1 comment · Fixed by #12
Labels
bug Something isn't working

Comments

@SARDONYX-sard
Copy link
Owner

SARDONYX-sard commented Oct 11, 2023

Version

0.1.5

Unexpected behavior here

It does not return an error even if it never performs a conversion.

Err(_) => continue, // NOTE: The first search is skipped because it does not yet lead to the DAR file.

Expected behavior

Returns an error if the conversion was never performed.
But I don't know how to construct that flag (should I just use an AtomicBool?).

static IS_CONVERTE_EXECUTED_ONCE: AtomicBool = AtomicBool(false);

if !IS_CONVERTE_EXECUTED_ONCE.load(Ordering::Acquire) {
    bail!("DynamicAnimationReplacer dir was never found")
}

Relevant log output

No response

@SARDONYX-sard SARDONYX-sard added the bug Something isn't working label Oct 11, 2023
@SARDONYX-sard SARDONYX-sard changed the title [Bug](Core): Err skipping is not safe. [Bug](Core): Err skipping is unsafe. Oct 11, 2023
SARDONYX-sard added a commit that referenced this issue Oct 11, 2023
SARDONYX-sard added a commit that referenced this issue Oct 11, 2023
@SARDONYX-sard SARDONYX-sard linked a pull request Oct 11, 2023 that will close this issue
1 task
@SARDONYX-sard
Copy link
Owner Author

Fixed by (#12)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant