-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support self-contained build without fallback dependency modules #731
Comments
Yes, this really makes sense. Since CSS files can't be bundled, you basically always have to use the I guess the main problem is that we don't know which JavaScript files might be required at runtime. So we would really like all of them to be available. I can see how we could omit all files that are part of the self-contained bundle from being written out separately, but I think you'd expect more, right? May I ask, how is this enhancement motivated? To reduce the deployment size? Would you expect debug sources to still be part of the build result? |
To be honest, I didn’t think much of aspect. My assumption was that all dependencies can be determined at build time.
Yes, my primary motivation is a significant size reduction of the deployment archive, along with performance gains in C/I (e.g. stashing of the build artefact between Jenkins nodes)
Yes I guess I would expect the debug sources to be there for all dependencies that are also part of |
Just to clarify: All dependencies determined at build time will of course be added to the self-contained bundle. The problem are those dependencies that we fail to detect (for example due to dynamic requires) and hence not add to the self-contained bundle. If those modules are not part of the build result, but the runtime suddenly needs to load them, the application might break. Thanks for your additional input, we'll discuss this in the team 👍 |
Is your feature request related to a problem? Please describe.
If a
self-contained
build with dependencies is performed, all framework dependencies will be also be included as non-bundled version. Although this behaviour makes sense as fallback option in case any resources were not included in the bundling, it would be good if it can be configured.Describe the solution you'd like
In given sample application project:
sap/m
Horizon
EN
It shall be possible to run a minimal self-contained build...
...that results in the following build output (simplified and no consideration of debug sources):
The text was updated successfully, but these errors were encountered: