diff --git a/.changeset/loud-poems-tickle.md b/.changeset/loud-poems-tickle.md new file mode 100644 index 000000000..03e6ccc9d --- /dev/null +++ b/.changeset/loud-poems-tickle.md @@ -0,0 +1,7 @@ +--- +"@ui5-language-assistant/vscode-ui5-language-assistant-bas-ext": patch +"vscode-ui5-language-assistant": patch +"@ui5-language-assistant/binding": patch +--- + +Fix type in documentation diff --git a/packages/binding/src/utils/documentation.ts b/packages/binding/src/utils/documentation.ts index f6b321cfd..73ba1a64f 100644 --- a/packages/binding/src/utils/documentation.ts +++ b/packages/binding/src/utils/documentation.ts @@ -53,9 +53,7 @@ const getType = (type: UI5Type | undefined): string[] => { result.push(data.join(" | ")); break; case "ArrayType": - if (type.type?.kind === "UI5Typedef") { - result.push(...getType(type.type)); - } + result.push(...getType(type.type)); break; } return result; diff --git a/packages/binding/test/unit/definition/__snapshots__/definition.test.ts.snap b/packages/binding/test/unit/definition/__snapshots__/definition.test.ts.snap index 30a565204..b0977ad98 100644 --- a/packages/binding/test/unit/definition/__snapshots__/definition.test.ts.snap +++ b/packages/binding/test/unit/definition/__snapshots__/definition.test.ts.snap @@ -3452,7 +3452,7 @@ Array [ -**Type:** +**Type:** sap.ui.model.Filter **Description:** An array of filters on which the logical conjunction is applied @@ -3817,7 +3817,7 @@ Array [ -**Type:** +**Type:** sap.ui.model.Filter **Description:** An array of filters on which the logical conjunction is applied diff --git a/packages/binding/test/unit/services/completion/__snapshots__/aggregation-binding.test.ts.snap b/packages/binding/test/unit/services/completion/__snapshots__/aggregation-binding.test.ts.snap index 03e59139a..7f3b83c0c 100644 --- a/packages/binding/test/unit/services/completion/__snapshots__/aggregation-binding.test.ts.snap +++ b/packages/binding/test/unit/services/completion/__snapshots__/aggregation-binding.test.ts.snap @@ -454,7 +454,7 @@ Array [ -**Type:** +**Type:** sap.ui.model.Filter **Description:** An array of filters on which the logical conjunction is applied @@ -679,7 +679,7 @@ Array [ -**Type:** +**Type:** sap.ui.model.Filter **Description:** An array of filters on which the logical conjunction is applied @@ -904,7 +904,7 @@ Array [ -**Type:** +**Type:** sap.ui.model.Filter **Description:** An array of filters on which the logical conjunction is applied @@ -1129,7 +1129,7 @@ Array [ -**Type:** +**Type:** sap.ui.model.Filter **Description:** An array of filters on which the logical conjunction is applied @@ -1663,7 +1663,7 @@ Array [ -**Type:** +**Type:** sap.ui.model.Filter **Description:** An array of filters on which the logical conjunction is applied @@ -1888,7 +1888,7 @@ Array [ -**Type:** +**Type:** sap.ui.model.Filter **Description:** An array of filters on which the logical conjunction is applied diff --git a/packages/binding/test/unit/services/hover/__snapshots__/hover.test.ts.snap b/packages/binding/test/unit/services/hover/__snapshots__/hover.test.ts.snap index 80286f9cd..00818e99f 100644 --- a/packages/binding/test/unit/services/hover/__snapshots__/hover.test.ts.snap +++ b/packages/binding/test/unit/services/hover/__snapshots__/hover.test.ts.snap @@ -19,6 +19,25 @@ Object { } `; +exports[`hover/index hover result on key - inside collection [ nested filters 02] 1`] = ` +Object { + "contents": Object { + "kind": "markdown", + "value": "\`(class) sap.ui.model.Filter\` + +--- + +**Type:** sap.ui.model.Filter + +**Description:** An array of filters on which the logical conjunction is applied + +**Optional:** true + +[More information](https://ui5.sap.com/1.108.1/#/api/sap.ui.model.Filter)", + }, +} +`; + exports[`hover/index hover result on key - inside collection [ nested filters] 1`] = ` Object { "contents": Object { diff --git a/packages/binding/test/unit/services/hover/hover.test.ts b/packages/binding/test/unit/services/hover/hover.test.ts index b8e9b10d4..e71de50d9 100644 --- a/packages/binding/test/unit/services/hover/hover.test.ts +++ b/packages/binding/test/unit/services/hover/hover.test.ts @@ -126,6 +126,21 @@ describe("hover/index", () => { const result = await getHover(snippet); expect(result).toMatchSnapshot(); }); + it("on key - inside collection [ nested filters 02]", async () => { + const snippet = ` + + `; + const result = await getHover(snippet); + expect(result).toMatchSnapshot(); + }); ["null", `''`, "0", "false"].forEach((value) => { it(`on key if ui5object has false value: ${value}`, async () => { const snippet = `