From c8b6ed270c5e5ddf6b4ede081b57e4dad0095880 Mon Sep 17 00:00:00 2001 From: anjana-bl Date: Thu, 22 Aug 2024 21:44:10 +0530 Subject: [PATCH] chore: removing unnecessary checks --- .../checkout-service-details.service.spec.ts | 24 ------------------- .../checkout-service-details.service.ts | 16 +++---------- 2 files changed, 3 insertions(+), 37 deletions(-) diff --git a/integration-libs/s4-service/checkout/core/facade/checkout-service-details.service.spec.ts b/integration-libs/s4-service/checkout/core/facade/checkout-service-details.service.spec.ts index 8be6c8ff048..fe896add77d 100644 --- a/integration-libs/s4-service/checkout/core/facade/checkout-service-details.service.spec.ts +++ b/integration-libs/s4-service/checkout/core/facade/checkout-service-details.service.spec.ts @@ -134,30 +134,6 @@ describe(`CheckoutServiceDetailsService`, () => { done(); }); }); - it(`should return undefined service detail if no service products are available in cart`, (done) => { - checkoutQuery.getCheckoutDetailsState = createSpy().and.returnValue( - of(>{ - loading: false, - error: false, - data: { - servicedAt: mockData, - }, - }) - ); - spyOn(cartService, 'getEntries').and.returnValue(of([])); - - service - .getSelectedServiceDetailsState() - .pipe(take(1)) - .subscribe((result) => { - expect(result).toEqual(>{ - loading: false, - error: false, - data: undefined, - }); - done(); - }); - }); }); describe(`setServiceScheduleSlot`, () => { diff --git a/integration-libs/s4-service/checkout/core/facade/checkout-service-details.service.ts b/integration-libs/s4-service/checkout/core/facade/checkout-service-details.service.ts index 0a18fbe6e6a..06575f2e198 100644 --- a/integration-libs/s4-service/checkout/core/facade/checkout-service-details.service.ts +++ b/integration-libs/s4-service/checkout/core/facade/checkout-service-details.service.ts @@ -90,19 +90,9 @@ export class CheckoutServiceDetailsService getSelectedServiceDetailsState(): Observable< QueryState > { - return this.checkoutQueryFacade.getCheckoutDetailsState().pipe( - switchMap((state) => { - return this.getServiceProducts().pipe( - map((products) => { - if (products.length > 0) { - return { ...state, data: state.data?.servicedAt }; - } else { - return { ...state, data: undefined }; - } - }) - ); - }) - ); + return this.checkoutQueryFacade + .getCheckoutDetailsState() + .pipe(map((state) => ({ ...state, data: state.data?.servicedAt }))); } getServiceProducts(): Observable {