Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When providing an invalid field in a POST request, SCIMException should be caught by the exception mappers but a JsonMappingException is caught #64

Open
VladislavStefanov opened this issue Feb 24, 2020 · 1 comment

Comments

@VladislavStefanov
Copy link
Contributor

In com.sap.scimono.entity.Resource the handleExtensionSchema method throws a SCIMException.
Probably something else should be done there.

Also, this SCIMException is caught by Jackson and is transformed into JsonMappingException, which makes it confusing because there is SCIMExceptionMapper and it could be assumed that this exception would be caught by this mapper but it is not.

@VladislavStefanov
Copy link
Contributor Author

Also if this exception occurs in another type of resource (group or schema) the exception is still with the text for user (Invalid user attribute: )

@VladislavStefanov VladislavStefanov changed the title When providing an invalid field in a POST request, it is not ignored, but a 400 response is returned When providing an invalid field in a POST request, SCIMException should be caught by the exception mappers but a JsonMappingException is caught Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant