Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Extract service provider logic from deploy-inq in deploy-shared module and add validation for cloud package #2631

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

GDamyanov
Copy link
Contributor

Feat for #2619

  • Extract common logic for service provider from "@sap-ux/abap-deploy-config-inquirer" in "@sap-ux/deploy-config-generator-shared"
  • Expose validation method checking if package is cloud in "@sap-ux/deploy-config-generator-shared"

Copy link

changeset-bot bot commented Nov 27, 2024

🦋 Changeset detected

Latest commit: 00d277e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@sap-ux/deploy-config-generator-shared Patch
@sap-ux/abap-deploy-config-inquirer Patch
@sap-ux/create Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

sonarcloud bot commented Nov 27, 2024

@testojs testojs self-requested a review November 27, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants