Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of the dreaded Beak #2414

Open
gpeuc opened this issue Sep 27, 2024 · 0 comments
Open

Removal of the dreaded Beak #2414

gpeuc opened this issue Sep 27, 2024 · 0 comments
Labels
ui-components @sap-ux/ui-components

Comments

@gpeuc
Copy link
Contributor

gpeuc commented Sep 27, 2024

Our various little popups currently have a little triangle beak which is attempting to point into the object that opened it. Like this:

Screenshot 2024-09-27 at 10 13 50 Screenshot 2024-09-27 at 10 13 58 Screenshot 2024-09-27 at 10 17 22

The main challenge with those was to try and align the beak with the object. In some cases due to various mathematical problems this was impossible. We had scenarios where top element (a chevron) is aligned to point between the pixels, and the beak was actually on half a pixel, and this caused them to look misaligned and messy.

Essentially due to the way various UI frameworks handle rotation, positioning, how they calculate the distances and width, we would end up in this situation too many times:

Screenshot 2024-09-27 at 10 27 32 Screenshot 2024-09-27 at 10 20 13

We have had too much time spent by our developers trying to align two objects, and just when they think they succeeded something breaks the alignment. For example, some users run their screens and VS Code / Browser at 120% zoom at all time due to accessibility needs. This +20% zoom causes all those mentioned UI frameworks to try and recalculate the position again, and something that was nicely positioned at 100% suddenly breaks at 120%.

Therefore, this is a dragon 🐉 that we keep chasing but we cannot catch. It's just easier for everyone to simply remove the beak.


All of the designs still look good, and I do not believe users will be confused without the beak. It's clear which element is the parent element of the popup, what exactly opened it.

Screenshot 2024-09-27 at 10 28 55 Screenshot 2024-09-27 at 10 28 58 Screenshot 2024-09-27 at 10 29 07

The beak on large mega-tooltips should stay. That one is OK.

Screenshot 2024-09-27 at 10 33 29

@815are

@vadson71

@gpeuc gpeuc added the ui-components @sap-ux/ui-components label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui-components @sap-ux/ui-components
Projects
None yet
Development

No branches or pull requests

1 participant