Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - Mockserver-config adds incorrect configuration to ui5-mock.yaml #2371

Open
1 of 3 tasks
johannes-kolbe opened this issue Sep 16, 2024 · 0 comments
Open
1 of 3 tasks
Labels
mockserver-config-writer @sap-ux/mockserver-config-writer

Comments

@johannes-kolbe
Copy link
Contributor

Description

  • The mockserver-config package adds incorrect initial configuration to the ui5-mock.yaml.
  • On updating the mockserver-config, existing entries are deleted and overwritten.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Run @sap-ux/create add mockserver-config
  2. See that ui5-mock.yaml is created,
    • mockdataPath is added, but the path is non-existent
  3. Add configuration to the yaml file
  4. In case of rerunning the command, this configuration is deleted, the standard config is created again

Expected results

  • Non-existing paths are not created
  • Standard configuration consists of empty service section:
 - name: sap-fe-mockserver
          beforeMiddleware: compression
          configuration:
              service:
  • Updating the configuration/rerunning the command updates the config correctly

Actual results

  • mockdataPath is always set
  • standard configuration has service section set with non-correct values
  • updating the config deletes the old config

Screenshots

If applicable, add screenshots to help explain the problem.

Version/Components/Environment

Add any other context about the problem here
OS:

  • Mac OS
  • Windows
  • Other

Root Cause Analysis

Problem

{describe the problem}

Fix

{describe the fix}

Why was it missed

{Some explanation why this issue might have been missed during normal development/testing cycle}

How can we avoid this

{if we don’t want to see this type of issues anymore what we should do to prevent}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mockserver-config-writer @sap-ux/mockserver-config-writer
Projects
None yet
Development

No branches or pull requests

1 participant