Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Field high in a ranges marked as required #322

Closed
schneidermic0 opened this issue Mar 10, 2022 · 4 comments · Fixed by #353
Closed

Field high in a ranges marked as required #322

schneidermic0 opened this issue Mar 10, 2022 · 4 comments · Fixed by #353
Assignees
@schneidermic0
Labels
bug Something isn't working

Comments

@schneidermic0
Copy link
Contributor

Field high in a range for CHKV is specified as required:

abap-file-formats/file-formats/chkv/type/zif_aff_chkv_v1.intf.abap

Line 22 in 6994c9a

"! $required

@schneidermic0 schneidermic0 added bug Something isn't working chkv labels Mar 10, 2022
@schneidermic0
Copy link
Contributor Author

Short addition: Most probably, field low is also not required because it accepts initial values.

However, I think it make sense to mark field low at least as $showAlways so that it is rendered even with initial values during serialization.

@schneidermic0
Copy link
Contributor Author

In general, the idea came up whether we should support TYPE RANGE OF in the AFF type interface to define ranges (instead of creating range structures and corresponding tables manually)

@schneidermic0 schneidermic0 mentioned this issue Apr 21, 2022
Merged
@schneidermic0 schneidermic0 self-assigned this Apr 21, 2022
@schneidermic0 schneidermic0 mentioned this issue Apr 21, 2022
Open
@schneidermic0
Copy link
Contributor Author

schneidermic0 commented Apr 21, 2022 •
edited
Loading

In general, the idea came up whether we should support TYPE RANGE OF in the AFF type interface to define ranges (instead of creating range structures and corresponding tables manually)

Created a new issue in abap-file-format-tools to support this. See SAP/abap-file-formats-tools#76

@schneidermic0
Copy link
Contributor Author

Also fixed with https://launchpad.support.sap.com/#/notes/3138884

This Note has been already linked in abapGit/abapGit#5279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schneidermic0 schneidermic0

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CHKV: Remove required fields low and high SAP/abap-file-formats
1 participant
@schneidermic0