Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zone Aggregation Take 2 #19

Closed
wants to merge 33 commits into from
Closed

Zone Aggregation Take 2 #19

wants to merge 33 commits into from

Conversation

DavidOry
Copy link
Collaborator

@DavidOry DavidOry commented Nov 9, 2022

Remove the sandag_abm files from #8

jpn-- and others added 30 commits April 29, 2022 13:43
@jpn--
initial zone agg
c0035e5
@vivekyadav26
Adding aggregation fields for zone aggregation
e0c3e9b
@vivekyadav26
Updating column references
6681e1e
@vivekyadav26
implementing explicit aggregation
44095f4
@jpn--
zone agg updates
ab6f497
@jpn--
notebook
660dbad
@jpn--
Merge branch 'main' into zone-agg
d11f655 
# Conflicts:
#	README.md
#	sandag_rsm/__init__.py
@jpn--
zone agg on TAZs
bc38c45
@jpn--
test data
136c7b9
@jpn--
git lfs
10f1de6
@jpn--
git-lfs in env
08433d0
@jpn--
add pyarrow dependency
dbb91f1
@jpn--
notes
89b6d4c
@jpn--
script to create test data
943d495
@DavidOry
Remove GIT LFS, point notebook to resources dir
279bee7
@jpn--
remove big files
8652779 
these are now in `resources`
@jpn--
remove big file
2d1df97
@jpn--
crosswalks and centroids
cb305fd
@jpn--
crosswalks and centroid mapping in notebook
46edf95
@elias-sanz
Translate Demand, initial commit
c4e4c09
@vivekyadav26
sandag model - 14.2.2
cb98e9c
@elias-sanz
Merge pull request #10 from elias-sanz/zone-agg
c848a73 
Translate Demand, initial commit
@jpn--
customizable start values for cluster_id
0f4598e
@vivekyadav26
Network Centroid Connectors
57d84bb 
Removing the existing centroid connectors and creating new ones based on aggregate zone structure
@vivekyadav26
Implement as method
e2d8f61
@jpn--
add load data function
23202e5
@jpn--
test data loader
5fc4822
@jpn--
Merge branch 'data-loader' into zone-agg
fea623d
@jpn--
fix error when no chdir
b99c07b
@jpn--
update notebook
13ce926
@DavidOry DavidOry mentioned this pull request Nov 9, 2022
Closed
This was linked to issues Nov 9, 2022
PRODUCT 1B: Translate Demand #12
Open
PRODUCT 1A Zone Creator: Sketch out MAZ Aggregation Algorithm #2
Open
PRODUCT 1A Zone Creator: First Pass at Algorithm for Transit Connectors #3
Open
@DavidOry DavidOry marked this pull request as ready for review November 9, 2022 20:15
@DavidOry
Copy link
Collaborator Author

DavidOry commented Nov 9, 2022

@AshishKuls, @JoeJimFlood: I've removed the sandag_abm files from this branch so we can review it.

@DavidOry
Copy link
Collaborator Author

DavidOry commented Nov 9, 2022

  • Add pytest infrastructure for unit testing
  • Convert the notebooks to tests to ensure that the resources repository and docker/anaconda environment remain up to date

DavidOry
DavidOry commented Nov 9, 2022
View reviewed changes
sandag_rsm/zone_agg.py
agg_instruction=None,
cluster_id="cluster_id",
):
if agg_instruction is None:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method documentation is needed

@AshishKuls AshishKuls closed this Jan 20, 2023
@AshishKuls AshishKuls deleted the zoneaggpr branch January 20, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@DavidOry @AshishKuls @jpn-- @vivekyadav26 @elias-sanz