Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Description in the Documentation for Loss Compensation #35

Open
maba-evo opened this issue Jun 27, 2024 · 1 comment
Open

Comments

@maba-evo
Copy link

It looks like there is something like a typo which makes it quite hard to implement the Loss Compensation.
The example file defines the LC property as follows:

...
 "LC": {
        "LN": "cable_name",
        "LI": 1,
        "LR": 2,
        "LU": "mOhm"
    },
...

In table 24 the LU property is defined as a required number, but the textual description defines the property as a string with either one of the two values "mOhm" or "uOhm".

I guess that the textual description is correct, but I am not 100% sure.
And if my assumption is right does this property use the same values as defined in table 20 Units.

Thanks and kind regards.

mhei added a commit to mhei/OCMF-Open-Charge-Metering-Format that referenced this issue Jul 11, 2024
The LU field is actually a string value, not a number. The was probably
a copy and paste error when adding this property.

And to make it more clear, add the reference to table 20 and the end
of the description.

Signed-off-by: Michael Heimpold <[email protected]>
@mhei
Copy link
Contributor

mhei commented Jul 11, 2024

Yes, I'm with you. Looks like a typo. I've created the referenced PR to fix it. It will be most probably discussed in the next OCMF UA meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants