Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular parent record references should be disallowed #24

Open
marksparkza opened this issue Feb 21, 2024 · 1 comment
Open

Circular parent record references should be disallowed #24

marksparkza opened this issue Feb 21, 2024 · 1 comment
Assignees

Comments

@marksparkza
Copy link
Member

A recursion error occurred when saving a record whose parent record was also its child. These two records were migrated from ODP v1 with this invalid relationship.

The records (or at least one of them) will need to be fixed manually in the DB. We also need to check all records to make sure there are no more such circular references.

The record API should be revisited to make sure it blocks any record create/update that would introduce such a circular reference - currently it looks like it only checks that the immediate parent is not a child.

@marksparkza marksparkza self-assigned this Feb 21, 2024
@marksparkza
Copy link
Member Author

I've updated those two records (10.15493/DEA.MIMS.26052100 and 10.15493/DEA.MIMS.26052101) in the DB - set parent_id to null. Then removed the IsPartOf relatedIdentifier in the metadata of each via ODP Admin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant