From 177e713cf0aad6495a347dbfa59ee981e6382b7e Mon Sep 17 00:00:00 2001
From: Sylwester Fraczek <sylwester.fraczek@intel.com>
Date: Wed, 24 Apr 2024 17:56:46 +0200
Subject: [PATCH] add validation of file names

---
 src/gui.rs |   6 ++-
 src/lib.rs | 108 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 113 insertions(+), 1 deletion(-)

diff --git a/src/gui.rs b/src/gui.rs
index b9f52a3..32e63ad 100644
--- a/src/gui.rs
+++ b/src/gui.rs
@@ -100,6 +100,10 @@ pub mod gui {
             let mut file_names: Vec<String> = vec![];
             let list_names = browser.borrow();
             log::info!("Processing {} files", list_names.size());
+            if list_names.size() == 0 {
+                log::info!("No files to process");
+                return;
+            }
             for i in 1..=list_names.size() {
                 let line_content = browser.borrow().text(i);
                 match line_content {
@@ -159,7 +163,7 @@ pub mod gui {
     ) {
         load_button.set_callback(move |_| {
             let mut chooser = dialog::FileDialog::new(dialog::FileDialogType::BrowseMultiFile);
-            chooser.set_directory(&".");
+            let _ = chooser.set_directory(&".");
             chooser.set_filter("*.{pdf,xlsx,csv}");
             chooser.set_title("Choose e-trade documents with transactions (PDF and/or XLSX)");
             chooser.show();
diff --git a/src/lib.rs b/src/lib.rs
index 4ffe52d..7e60b3b 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -249,6 +249,55 @@ fn compute_sold_taxation(transactions: &Vec<SoldTransaction>) -> (f32, f32) {
 
 pub fn format_sold_transactions_to_string() {}
 
+use std::collections::HashSet;
+use std::path::Path;
+use std::ffi::OsStr;
+
+/* Check:
+if file names have no duplicates
+if there is only one xlsx spreadsheet
+if extensions are only pdf, csv, xlsx
+*/
+pub fn validate_file_names(files: &Vec<String>) -> Result<(), String> {
+    let mut names_set = HashSet::new();
+    let mut spreadsheet_count = 0;
+    let mut errors = Vec::<String>::new();
+    
+    for file_str in files {
+        let path = Path::new(&file_str);
+        if !path.is_file() {
+            errors.push(format!("Not a file or path doesn't exist: {}", file_str));
+            continue;
+        }
+
+        if let Some(file_stem) = path.file_stem().and_then(OsStr::to_str) {
+            if !names_set.insert(file_stem.to_owned()) {
+                let file_name = path.file_name().and_then(OsStr::to_str).unwrap();
+                errors.push(format!("Duplicate file name found: {}", file_name));
+            }
+        } else {
+            // Couldn't test it on windows.
+            errors.push(format!("File has no name: {}", file_str));
+        }
+        
+        match path.extension().and_then(OsStr::to_str) {
+            Some("xlsx") => spreadsheet_count += 1,
+            Some("csv") | Some("pdf") => {},
+            Some(other_ext) => errors.push(format!("Unexpected extension {other_ext} for file: {file_str}. Only pdf, csv and xlsx are expected.")),
+            None => errors.push(format!("File has no extension: {}", file_str))
+        }
+    }
+
+    if spreadsheet_count > 1 {
+        errors.push(format!("Expected a single xlsx spreadsheet, found: {}", spreadsheet_count));
+    }
+    
+    if errors.len() > 0 {
+        return Err(errors.join("\n"));
+    }
+    Ok(())
+}
+
 pub fn run_taxation(
     rd: &Box<dyn Residency>,
     names: Vec<String>,
@@ -265,6 +314,8 @@ pub fn run_taxation(
     ),
     String,
 > {
+    validate_file_names(&names)?;
+    
     let mut parsed_interests_transactions: Vec<(String, f32)> = vec![];
     let mut parsed_div_transactions: Vec<(String, f32, f32)> = vec![];
     let mut parsed_sold_transactions: Vec<(String, String, f32, f32, f32)> = vec![];
@@ -378,6 +429,63 @@ pub fn run_taxation(
 #[cfg(test)]
 mod tests {
     use super::*;
+    
+    #[test]
+    fn test_validate_file_names_invalid_path() {
+        let files = vec![
+            String::from("file1.csv"),
+            String::from("data/G&L_Expanded.xlsx"),
+            String::from("data"),
+        ];
+
+        let result = validate_file_names(&files);
+        assert_eq!(result.err(), Some(String::from("Not a file or path doesn't exist: file1.csv\nNot a file or path doesn't exist: data")));
+    }
+
+    #[test]
+    fn test_validate_file_names_two_spreadsheets() {
+        let files = vec![
+            String::from("data/G&L_Expanded.xlsx"),
+            String::from("data/G&L_Collapsed.xlsx"),
+            String::from("revolut_data/revolut-savings-eng.csv"),
+            String::from("revolut_data/Revolut_21sie2023_27lis2023.csv"),
+        ];
+
+        let result = validate_file_names(&files);
+        assert_eq!(result.err(), Some(String::from("Expected a single xlsx spreadsheet, found: 2")));
+    }
+
+    #[test]
+    fn test_validate_file_names_duplicate_file() {
+        let files = vec![
+            String::from("data/G&L_Expanded.xlsx"),
+            String::from("data/G&L_Expanded.xlsx"),
+        ];
+
+        let result = validate_file_names(&files);
+        assert_eq!(result.err(), Some(String::from("Duplicate file name found: G&L_Expanded.xlsx\nExpected a single xlsx spreadsheet, found: 2")));
+    }
+
+    #[test]
+    fn test_validate_file_names_unexpected_extension() {
+        let files = vec![
+            String::from("Cargo.toml"),
+            String::from("revolut_data/revolut-savings-eng.csv"),
+            String::from("revolut_data/Revolut_21sie2023_27lis2023.csv"),
+        ];
+
+        let result = validate_file_names(&files);
+        assert_eq!(result.err(), Some(String::from("Unexpected extension toml for file: Cargo.toml. Only pdf, csv and xlsx are expected.")));
+    }
+
+    #[test]
+    fn test_validate_file_names_no_extension() {
+        let files = vec![String::from("LICENCE")];
+
+        let result = validate_file_names(&files);
+        assert_eq!(result.err(), Some(String::from("File has no extension: LICENCE")));
+    }
+
     #[test]
     fn test_simple_div_taxation() -> Result<(), String> {
         // Init Transactions