-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the auto grading look nicer #358
Comments
Sure, I agree with you! Overall my thoughts were that readability > less code / fewer lines. I agree with you that the last two lines could be turned into one and delete the |
I see. For the second point, they've always sent us screenshots or a copy and paste of the error message. So I think it's safe to just delete the json. For the first I agree that telling them where the tests are is good for debugging. But couldn't we do it explicitly? Like adding a sentence to the markdown above the final cell saying something like "You can check your work by running the following cell. This will grade your implementation running the battery of tests written in |
@wilkosch: I think it'd be nice to make the autograding cell at the end of the notebooks look nicer. What do you think?
For example, would the addition of some
__init__.py
files prevent us from writing the long import lines? Also, can theGrader
class provide a single function that wraps the actual grading and the printing?One more related thing. Is there a reason why you decided not to delete the
results.json
file after you run the grader? Every time I run the grader, I get an unstaged file in git. We could add.json
to the.gitignore
, but I think it'd be cleaner to just delete thejson
s after grading.The text was updated successfully, but these errors were encountered: