Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devise_invitable callbacks are made useless with this gem #3

Open
krue-doug opened this issue Jun 13, 2018 · 0 comments
Open

devise_invitable callbacks are made useless with this gem #3

krue-doug opened this issue Jun 13, 2018 · 0 comments

Comments

@krue-doug
Copy link

krue-doug commented Jun 13, 2018 •
edited
Loading

I dug into the code, and I noticed that you are only using devise_invitable to create the invite when someone accepts the invite created by this gem. This effectively causes the callbacks (such as before_invitation_created, after_invitation_created) provided devise_invitable to create side effects. For example, when a user accepts the invitation created by this gem then it would call hooks in before_invitation_created from devise_invitable which is unexpected.
@krue-doug krue-doug changed the title An invitation isn't created when you use rails c devise_invitable callbacks are made useless with this gem Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@krue-doug