[Performance] Configuration option access causes performance issue on spawner block ticking

[R00tB33rMan]

Potential solution: Cache the configuration (on) fields to avoid map lookup.

Full report: https://spark.lucko.me/4kMcAEDqpF

[Esophose]

I can at least confirm that isn't the cause of your TPS being 8, the hashmap lookups are mostly negligible. I'll consider inlining those settings since they show up at all, just know it wont make any noticeable performance difference

[R00tB33rMan]

I can at least confirm that isn't the cause of your TPS being 8, the hashmap lookups are mostly negligible. I'll consider inlining those settings since they show up at all, just know it wont make any noticeable performance difference

Oh no, this isn't to infer that your resource is incurring major depreciation issues. We can handle a cap of ~600 concurrent on 1.21.1 @ 20 TPS. This was primarily due to all of the RTPs, among other things. We're just ensuring that your resource is as best as it can be. Better to report these issues and optimize 'em, despite their neglibility.